fix: Android OOM by eliminating intermediate buffer copies#54854
Open
DorianMazur wants to merge 4 commits intofacebook:mainfrom
Open
fix: Android OOM by eliminating intermediate buffer copies#54854DorianMazur wants to merge 4 commits intofacebook:mainfrom
DorianMazur wants to merge 4 commits intofacebook:mainfrom
Conversation
Contributor
Author
|
CC: @robhogan |
|
@DorianMazur #ask is there full repo to test this PR ? thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
During JS bundle downloads from Metro, the multipart stream reader was copying each chunk into a new Buffer before passing it to listeners. For large bundles, this resulted in elevated peak memory usage due to duplicating chunk data (Okio read buffer + intermediate Buffer copy, plus downstream buffering), which can exceed emulator heap limits for large bundles.
Example: #52818
Repro: #52797
Changes
BufferedSourceper part (prevents reading past the part into the next boundary) and drain unread bytes after callbacks so listeners don’t need to fully consume the body..tmp+ rename) to avoid partial bundles on interruption.X-Http-Statussafely.Changelog:
[ANDROID] [FIXED] - Reduced memory usage during JS bundle downloads by eliminating intermediate buffer copies
Test Plan: